Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation tests for sysctls #139

Merged
merged 1 commit into from
Sep 20, 2017
Merged

Add validation tests for sysctls #139

merged 1 commit into from
Sep 20, 2017

Conversation

feiskyer
Copy link
Member

Part of #24.

@feiskyer feiskyer requested a review from xlgao-zju September 19, 2017 05:49
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 19, 2017
@feiskyer feiskyer requested a review from Random-Liu September 19, 2017 05:49
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2017
@feiskyer feiskyer mentioned this pull request Sep 19, 2017
Closed
3 tasks
@Random-Liu
Copy link
Contributor

LGTM

@Random-Liu Random-Liu added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2017
@Random-Liu Random-Liu self-assigned this Sep 20, 2017
@Random-Liu Random-Liu merged commit 27e8fc3 into kubernetes-sigs:master Sep 20, 2017
@feiskyer feiskyer deleted the sysctls-validation branch September 21, 2017 00:23
@feiskyer feiskyer mentioned this pull request Sep 22, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlgao-zju xlgao-zju Awaiting requested review from xlgao-zju

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feiskyer @Random-Liu @k8s-ci-robot